Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vim command line to edit file uses incorrect path #746

Closed
lzybkr opened this issue Sep 9, 2016 · 4 comments
Closed

Using vim command line to edit file uses incorrect path #746

lzybkr opened this issue Sep 9, 2016 · 4 comments

Comments

@lzybkr
Copy link

lzybkr commented Sep 9, 2016

What did you do?

ESC : e e:\src\PowerShell\build.psm1

What did you expect to happen?

open the file e:\src\PowerShell\build.psm1

What happened instead?

attempt to open the file c:\current\dir\e:\src\PowerShell\build.psm1
and offer to create that file

Technical details:

  • VSCode Version: 1.5.1
  • VsCodeVim Version: 0.1.10
  • OS: Windows 10 Anniversary Update
@rebornix
Copy link
Member

@lzybkr currently the way we handle path is using current folder as base path. Apparently we can improve this feature.

@jpoon jpoon added the kind/bug label Sep 12, 2016
@jpoon
Copy link
Member

jpoon commented Sep 12, 2016

Seems like we should figure out whether the path is an absolute path. Otherwise assume it's relative.

@jpoon jpoon added the size/XS label Sep 12, 2016
@johnfn
Copy link
Member

johnfn commented Sep 20, 2016

We should probably use some sort of path resolver module. Lots of tricky edge cases here.

@johnfn johnfn added size/S and removed size/XS labels Sep 20, 2016
@rebornix
Copy link
Member

path.isAbsolute already does the trick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants