Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:w and :wa don't work properly with SSHFS and LiveShare guest #3304

Closed
wilbur4321 opened this issue Dec 29, 2018 · 2 comments
Closed

:w and :wa don't work properly with SSHFS and LiveShare guest #3304

wilbur4321 opened this issue Dec 29, 2018 · 2 comments

Comments

@wilbur4321
Copy link

Describe the bug
:w produces an "ENOENT: no such file or directory, access C:..." when you are saving a file opened through the SSHFS extension. :wa works with this extension. Ctrl-S to save works as well.

With VS LiveShare (as a guest), both show success, but they appear to just write to the local file, and not save on the server. Again, Ctrl-S works properly.

To Reproduce
Steps to reproduce the behavior:

Add the "SSH FS" extension from https://marketplace.visualstudio.com/items?itemName=Kelvin.vscode-sshfs. Configure a remote connection and add it to your workspace. Open a file within, and observe the above behavior when using :w.

Configure LiveShare. Share your session (the system doing the sharing doesn't even need VSCodeVim). Connect to LiveShare from a VSCode with VSCodeVim (aka, client). Open the same file on both, make a change in the client, use :w to save, and observe that the other system shows the file as not having been written. Now, use Ctrl-S to save, and observe that the other system shows the file as having been written.

Expected behavior
:w should write the file the same as Ctrl-S. :wa should do the same as a save-all.

Environment (please complete the following information):

  • Issue Type: Bug
  • Extension Name: vim
  • Extension Version: 0.17.0
  • OS Version: Windows_NT x64 10.0.17134
  • VSCode version: 1.30.1
{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 188,
		"activateCallTime": 0,
		"activateResolvedTime": 998,
		"activationEvent": "*"
	}
}
@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

Closing as duplicate of #2956

@wilbur4321
Copy link
Author

Sorry about the duplicate, and thanks for the fix! I greatly appreciate it!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants