Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linewise visual mode :sort not supported #1592

Closed
apexskier opened this issue Apr 27, 2017 · 2 comments
Closed

Linewise visual mode :sort not supported #1592

apexskier opened this issue Apr 27, 2017 · 2 comments
Labels
help wanted kind/bug

Comments

@apexskier
Copy link

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

What did you do?

V3j
:sort⏎

What did you expect to happen?

The highlighted lines would be sorted with the sort command.

What happened instead?

The entire file was sorted with the sort command.

Technical details:

  • VSCode Version: 1.11.2
  • VsCodeVim Version: 0.6.20
  • OS: macOS 10.12.3

related to #1342
@Chillee
Copy link
Member

Chillee commented May 1, 2017 •
edited
Loading

We'll probably wait for the api call linked in #792 to pop up before we add this.

@rebornix
Copy link
Member

rebornix commented May 1, 2017

#1342 already added the function for range sorting, however we didn't take selection into account. It's an easy fix.

@rebornix rebornix mentioned this issue May 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apexskier @rebornix @Chillee