Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertions #702

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix assertions #702

merged 2 commits into from
Apr 25, 2022

Conversation

kkarbowiak
Copy link
Contributor

@kkarbowiak kkarbowiak commented Apr 23, 2022 •
edited by jcoupey
Loading

Issue #701

This PR fixes the assertions by changing the assignments to equality checks as was originally intended.

Tasks

  • test
  • review

jcoupey
jcoupey approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this on some plan mode test cases I used during dev and the new assert checks don't break. It simply means that the assertion where rightly placed at the time but ineffective.

Could you please add a changelog entry for this?

@jcoupey jcoupey added this to the v1.12.0 milestone Apr 25, 2022
@jcoupey jcoupey merged commit 6484209 into VROOM-Project:master Apr 25, 2022
@jcoupey jcoupey mentioned this pull request Apr 25, 2022
Closed
@kkarbowiak kkarbowiak deleted the fix-assertions branch September 9, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoupey jcoupey jcoupey approved these changes

Assignees
No one assigned
Labels
bug compilation plan mode
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kkarbowiak @jcoupey