Remove duplicate definition of LocalSearch

[jonathf]

Issue

#634:
Python requires a large list of includes in memory at all given times. Using the same name in the same namespace causes compile issues.

The proposed minimal solution is to just rename the conflicting variable, but removing the name all together is also possible here as it is only used for convinience.

Tasks

• Update CHANGELOG.md (remove if irrelevant)
• review

[jcoupey]

Thanks for the PR. If I get it right, the conflict is between the local LocalSearch type defined with "using" in vrptw.cpp and the one defined in src/algorithms/local_search/local_search.h? Then the same problem probably exists within src/problems/cvrp/cvrp.cpp?

What if we use a more specific local name, e.g. using VRPTWLocalSearch = ... and using CVRPLocalSearch = ... in vrptw.cpp and cvrp.cpp respectively? Or maybe even better we can namespace them as vrptw::LocalSearch and cvrp::LocalSearch?

[jonathf]

Yes, that follows. pyvroom isn't feature complete yet, so it will likely not catch everything round one.

I like the namespace solution best. I can implement it if you like.

[jonathf]

It is update now, @jcoupey.

I am realizing through the trenches of undeciphrable C++ error messages, that the name conlfict might not be against src/algorithms/local_search/local_seach.h since it is already in another namesspace. The conflict is more likely between cvrp.cpp and vrptw.cpp which both uses the root vroom namespace. Either way, butting both in seperate namespaces solves the issue on my side.