Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sphinx documentation #11

Open
jonathf opened this issue Jan 2, 2022 · 11 comments
Open

Add Sphinx documentation #11

jonathf opened this issue Jan 2, 2022 · 11 comments
Labels
documentation Improvements or additions to documentation

Comments

@jonathf
Copy link
Collaborator

jonathf commented Jan 2, 2022

No description provided.

@jonathf jonathf added the documentation Improvements or additions to documentation label Jan 2, 2022
@jonathf jonathf closed this as completed Jan 5, 2022
@jonathf jonathf reopened this Jan 5, 2022
@jonathf
Copy link
Collaborator Author

jonathf commented Jul 22, 2024

@jcoupey, I made a first pass at gathering the Python documentation together now at #114. Do you have a preference as to where we should host it?

I see the following alternatives as viable:

@jcoupey
Copy link
Contributor

jcoupey commented Jul 29, 2024

Thanks for asking, I'd be in favor of using the vroom-project domain as main entry point. I can take care of uploading/updating the docs there whenever needed. What would the publishing process look like?

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 1, 2024

Building docs is done with a single build command that generates an html folder ready for publication.

My preference is to have something automatic set up in cicd.

@jcoupey
Copy link
Contributor

jcoupey commented Aug 4, 2024

If the build is done on CI, I could automatically rsync that to http://vroom-project.org/pyvroom, but not sure how we'd store the CI build though? What I could do easily is setup a cron job to push + build daily on the machine serving the website.

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 4, 2024

If you want to pull instead of push changes then I suggest we store CI output in an intermediate dedicated repo like pyvroom-docs. pyvroom will autmatically push changes to this repo and your cron can then pull from this repo asyncronously.

@jcoupey
Copy link
Contributor

jcoupey commented Aug 8, 2024

Sure, sounds like a good process. I actually wrote "push" in my previous message but meant "pull"...

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 12, 2024

Great. Do you mind making the doc repo and adding a depoloy token here with push rights?

@jcoupey
Copy link
Contributor

jcoupey commented Aug 20, 2024

@jonathf just created the pyvroom-docs repo and added you as a maintainer. Does this gives your rights for the token thing?

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 20, 2024

Unfortunatly no.

A deploy key needs to be added to pyvroom-docs with write access. The same key needs to be added to pyvroom as a repository secret.

With this in place, I can do the rest.

@jcoupey
Copy link
Contributor

jcoupey commented Aug 20, 2024

Thanks for the pointers. I just created a dedicated ssh key, added the public key as a deploy key with write access in pyvroom-docs and set the private key as SSH_PRIVATE_KEY secret in this repo. Let me know if that works!

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 20, 2024

Excellent! I'll take a look at it when I have some more time to spare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants