Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIクライアントのFactoryを作って、動的にAPIクライアントを変更できるようにする #420

Merged
merged 6 commits into from
Oct 31, 2021
Merged

APIクライアントのFactoryを作って、動的にAPIクライアントを変更できるようにする #420

merged 6 commits into from
Oct 31, 2021

Commits on Oct 30, 2021

  1. OpenAPIのAPIClientのインスタンスを管理するFactoryを実装し、Storeが直接OpenAPIに依存しないような準備をする

    @yamachu
    yamachu committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    8ad2c98 View commit details
    Browse the repository at this point in the history

  2. AudioStoreのstateでEngineFactoryのInterfaceの実装を管理するようにし、Store内部では当該Facto… 

    …ryからAPIClientの実装を受け取るようにする
    @yamachu
    yamachu committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    59ccfef View commit details
    Browse the repository at this point in the history

  3. audioでconnectionの情報を管理するのもなんか違うので、settingsのstoreの情報を使うようにする

    @yamachu
    yamachu committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    24c498b View commit details
    Browse the repository at this point in the history

  4. テスト通すためにダミーの実装を追加

    @yamachu
    yamachu committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    f0303b8 View commit details
    Browse the repository at this point in the history

  5. Storeをクロージャーで生成して、その段階でDIを行う

    @yamachu
    yamachu committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    23d3417 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. Merge branch 'main' into api-interface

    @yamachu
    yamachu committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    1be4349 View commit details
    Browse the repository at this point in the history