[project-s] リファクタリング #1735
Merged
[project-s] リファクタリング #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 21, 2024
| @@ -1097,6 +1099,35 @@ export default defineComponent({ | |||
| position: relative; | |||
| } | |||
|
|
|||
| .sequencer-grid { | |||
There was a problem hiding this comment.
gridはきれいにコンポーネントに分けられそうだなと思いました！
（Vueは体感700行くらい超えてくると結構コーディングが重くなってくるので。。。）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
ScoreSequencer.vue、ToolBar.vue、singing.ts、domain.tsのリファクタリングstate.phrasesの型をRecord<string, Phrase>からMap<string, Phrase>に変更guideLineTicksを保持するように変更isValidBpm、isValidBeatsを追加し、ToolBar.vueでそれらを呼ぶように変更getSnapTypesとisValidSnapTypeをdomain.tsに移動OverlappingNotesDetectorにclear()を追加NOTE_IDS（getter）を追加=== undefined、!== undefinedの箇所を修正関連 Issue
VOICEVOX/voicevox_project#15
その他