fix(useFloatingWithInteractions): improve restoreFocus, add restoreFocus to anchor element #7806
+97
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cus to anchor element
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 5b9d4ea |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7806 +/- ##
==========================================
- Coverage 95.34% 95.29% -0.05%
==========================================
Files 377 377
Lines 11054 11075 +21
Branches 3673 3682 +9
==========================================
+ Hits 10539 10554 +15
- Misses 515 521 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
added
patch
vkcom-publisher
added
the
pr-needs-work
EldarMuhamethanov
removed
the
pr-needs-work
# Conflicts: # packages/vkui/src/components/FocusTrap/FocusTrap.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Нужно добавить возможность настройки элемента, куда будет возвращаться фокус после закрытия поповера по ховеру.
Изменения
В
PopoverиTooltipрасширил тип свойстваrestoreFocus. Теперь помимоbooleanон может принимать следующие значения:'latest-active' - означает, что фокус будет возвращен на последний активный до открытия всплывающего окна элемент. По сути это поведение по умолчанию'anchor-element'- означает, что фокус будет возвращен на якорный элементHTMLElement- можно использовать ссылку на определенный html элементТакже изменения затронули компонент
FocusTrap:restoreFocusможно прокинуть, помимо функции, возвращающейboolean, функцию, возвращающуюHTMLElement(() => boolean | HTMLElement).Теперь, чтобы поправить баг описанный в задаче необходимо для
Popoverсtrigger="hover"прокинутьrestoreFocus="anchor-element"Release notes
Улучшения
restoreFocusдоboolean | 'latest-active' | 'anchor-element' | HTMLElementдля указания на какой элемент будет возвращен фокус после закрытияPopover. Полезно для кейса сPopoverсtrigger="hover", при установкеrestoreFocus="anchor-element"фокус всегда будет возвращаться в якорный элемент