-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use reusable workflows from pyTooling/Actions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2021
Codecov Report
@@ Coverage Diff @@
## dev #36 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 4 4
Lines 2307 2307
Branches 355 355
=======================================
Hits 1710 1710
Misses 584 584
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
umarcor
force-pushed
the
ci-pyactions
branch
2 times, most recently
from
November 29, 2021 02:27
94b13e5
to
ce12fc0
Compare
umarcor
force-pushed
the
ci-pyactions
branch
from
November 29, 2021 19:55
ce12fc0
to
3ce40af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the CI Pipeline is reworked in order to use reusable workflows from pyTooling/Actions (see pyTooling/Actions#1).
Each job is replaced with a call to a reusable workflow, except
VerifyDocs
. That's becauseVerifyDocs
in this repo requires GHDL. However, that's actually an advantage of having 10 reusable workflows (one per job), instead of a single constrained reusable workflow.The logic for dealing with global parameters is changed. Currently, GitHub Actions does not support using global env variables as arguments when calling reusable workflows (see actions/runner#480). As a workaround, job
Params
generates a JSON struct of values that can be later used in other jobs.MPORTANT: reusable workflows must be used through an absolute name and specifying a version (see actions/runner#1493). Therefore, this PR will be kept as a draft, because s/@dev/@main/ is required in
Pipeline.yml
before merging.