Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reusable workflows from pyTooling/Actions #36

Merged
merged 19 commits into from
Dec 1, 2021
Merged

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Nov 27, 2021

In this PR, the CI Pipeline is reworked in order to use reusable workflows from pyTooling/Actions (see pyTooling/Actions#1).

Each job is replaced with a call to a reusable workflow, except VerifyDocs. That's because VerifyDocs in this repo requires GHDL. However, that's actually an advantage of having 10 reusable workflows (one per job), instead of a single constrained reusable workflow.

The logic for dealing with global parameters is changed. Currently, GitHub Actions does not support using global env variables as arguments when calling reusable workflows (see actions/runner#480). As a workaround, job Params generates a JSON struct of values that can be later used in other jobs.

MPORTANT: reusable workflows must be used through an absolute name and specifying a version (see actions/runner#1493). Therefore, this PR will be kept as a draft, because s/@dev/@main/ is required in Pipeline.yml before merging.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #36 (c5c8555) into dev (e40e3b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #36   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files           4        4           
  Lines        2307     2307           
  Branches      355      355           
=======================================
  Hits         1710     1710           
  Misses        584      584           
  Partials       13       13           
Flag Coverage Δ
unittests 74.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40e3b9...c5c8555. Read the comment docs.

@umarcor umarcor force-pushed the ci-pyactions branch 2 times, most recently from 94b13e5 to ce12fc0 Compare November 29, 2021 02:27
@umarcor umarcor marked this pull request as ready for review December 1, 2021 00:13
@Paebbels Paebbels merged commit 90f7f2b into dev Dec 1, 2021
@Paebbels Paebbels deleted the ci-pyactions branch December 1, 2021 06:28
@Paebbels Paebbels restored the ci-pyactions branch December 1, 2021 06:28
@umarcor umarcor deleted the ci-pyactions branch December 1, 2021 06:31
@umarcor umarcor added the enhancement New feature or request label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants