Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation / install instructions, several problems #226

Closed
lscheffler opened this issue Dec 1, 2023 · 2 comments
Closed

Documentation / install instructions, several problems #226

lscheffler opened this issue Dec 1, 2023 · 2 comments

Comments

@lscheffler
Copy link
Contributor

lscheffler commented Dec 1, 2023

The file Docs/Thor_install.md states:

Extract the Thor-master\Installed Files subdirectory from the ZIP file to the installation folder of your choice (see details below on how to choose an installation folder ). After this step your installation folder should only contain the Source folder and Thor.APP.

The Installed Files subdirectory in the zip contains Source directory and Thor.APP file and Thor directory.


The file links to download https://github.com/VFPX/Thor/archive/master.zip and extract files from some subdirectory. This is overcomplicated and error prone. A lot of people end up with Thor/Installed Files or Thor/Thor-master/Installed Files
A link to Thor.zip (https://github.com/VFPX/Thor/raw/master/ThorUpdater/Thor.zip) should do. Installed Files is the content of Thor.zip?

@lscheffler
Copy link
Contributor Author

It looks like the Thor directory mentioned above is the important part. The Source is compiled into the App, there is no need to put this on the install folder.

If one expand ThorUpdater/Thor.zip without the Source directory, it looks likes it runs without a problem. The Thor.h and the related are missing if one must compile some of the prgs (by implementing #225).
Either

  • one tells the ps1 script only to include the files one need
  • does not code in "Installed Files", but use something like VFPXDeployment to move the files needed to Installed Files" directory
  • moves the header files

@Jimrnelson
Copy link
Collaborator

Suggested changes have been made to the installation document for Thor (as well as a few other minor edits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants