Use more standard method for registering GF with Thor

[Jimrnelson]

The standard way for registering GF with Thor (supported by VFPX Deployment) is that the creation of the Thor Tool be created within the Version file.

GF actually has this embedded in the GoFish.App.

(For reasons I could never grasp, Matt Slay wanted the Thor Tools to be registered every time GF was called, which meant it had to be baked into GF.)

[lscheffler]

I vote for removing this from GF.

[Jimrnelson]

@lscheffler

I vote for removing this from GF.

If you mean by this removing the code from GoFish.App and adding it instead to the Version file (which only exists and is referenced as part of Thor CFU), I heartedly agree.

[lscheffler]

@Jimrnelson
Hi Jim, may I ask your support on this?
I'm moving forward, but I have no good idea about the Thor stuff to enter.

The most recent development state is at https://github.com/lscheffler/GoFish, clone [email protected]:lscheffler/GoFish.git and use the dev branch. The file that should hold the Thor code is BuildProcess\Thor_Update_GoFish.prg (https://github.com/lscheffler/GoFish/blob/dev/BuildProcess/Thor_Update_GoFish.prg)

Could you alter this so that it does what it should do?

Thanks

[Jimrnelson]

Sure, will do so over the weekend if time permits.

This is mostly migrating code from with GF.App into the version file. However, it's tricky to test.

[Jimrnelson]

If you want to use this as a way to introduce me to branching, it will have to wait until well into January.

I actually don't need any of your updated source code to provide a solution to this issue, as I will only be modifying your version template file (which I can attach here).

[lscheffler]

Okay.
But it would be really simple, just to enable the testing. Nothing fancy. No harm to existing stuff. 3 commands on git you enter blindly, the rest as you do all the time. VFPXDeployment. And set up a vanilla Thor, copy a file to the My Updates folder, then run CFU.

[Jimrnelson]

OK, then, this can certainly wait until at least late January.

That's actually better for me, as I was gonna have to find the time to squeeze this in if I worked on it over the weekend.

I've got plenty going on to keep me busy until then.

[lscheffler]

In this case, just send me the file, I do the testing.

Edit: ... and we keep it outside git history.

[Jimrnelson]

OK, will do.

[Jimrnelson]

This has been taken care of. Months ago, actually.