Mesa fix layout #1298
Merged
Mesa fix layout #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurreco-uga
approved these changes
Dec 9, 2024
bobular
reviewed
Dec 10, 2024
| const { columns } = this.props; | ||
| const hasSelectionColumn = this.hasSelectionColumn(); | ||
| const { contentTable, getInnerCellWidth } = this; | ||
| this.setState({ dynamicWidths: null }, () => { |
There was a problem hiding this comment.
I'm confused as to where this.state.dynamicWidths is ever accessed?
This seems to be more about setting this.widthCache.
There was a problem hiding this comment.
Thanks for catching. That was an oversight. I meant to purge all occurrences of dynamicWidths. Will fix in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some recently introduced layout issues with Mesa table, specifically when rows are either selectable or expandable.
With the relatively recently
position: stickycss value, we can dramatically simplify the html and remove a decent amount of runtime javascript.These changes impact all uses of Mesa table:
Seeing as this is an urgent fix (the bug is on production), I would appreciate a quick review. I'm happy to go over changes in more detail, after this is merged.