Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integer bins w width of 1 #37

Merged
merged 3 commits into from
Feb 21, 2024
Merged

fix integer bins w width of 1 #37

merged 3 commits into from
Feb 21, 2024

Conversation

d-callan
Copy link
Member

see VEuPathDB/web-monorepo#762 for context.

bobular
bobular approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't fully understand the boundary stuff, but I see from the comments we might never use it. The second expect_equal test is how we'd use cut_width in practice and it looks good to me.

@d-callan d-callan merged commit 16dce63 into main Feb 21, 2024
5 checks passed
@d-callan d-callan deleted the integer-bins branch February 21, 2024 14:16
@d-callan d-callan mentioned this pull request Feb 21, 2024
Closed
@d-callan d-callan mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobular bobular bobular approved these changes

@asizemore asizemore Awaiting requested review from asizemore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-callan @bobular