Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up alias query/plugin config #40

Closed
ryanrdoherty opened this issue Jul 25, 2022 · 0 comments · Fixed by #42
Closed

Fix up alias query/plugin config #40

ryanrdoherty opened this issue Jul 25, 2022 · 0 comments · Fixed by #42
Assignees
Labels
bug Something isn't working

Comments

@ryanrdoherty
Copy link
Member

Multiple issues found that can be fixed together:

  1. 1 primary key def can be made in XML (last one selected); add include/exclude logic and throw error if 0 or >1 remains

  2. If query and plugin are both null, we will always throw NotFound for all IDs of the recordclass; this should not be possible, so error on model parse if both are null (maybe change RNG to require one)
  3. To make logic more clear, if query is selected, wrap in a plugin and then always just user plugin logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant