Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing results part1 #8

Open
lagerweijgr opened this issue Oct 14, 2024 · 4 comments
Open

Testing results part1 #8

lagerweijgr opened this issue Oct 14, 2024 · 4 comments

Comments

@lagerweijgr
Copy link
Collaborator

for @chStaiger

  1. Can there be a check for the numbers in the environment_events versus environment?
    I had no environment_id in the “environment.csv” however there were event_ids in the “environment_event.csv”.

  2. Event_time.
    I have put in 08:00 in the code sees this as float64 but it should be a string? How ?

@chStaiger
Copy link
Member

@lagerweijgr
What is the exact logic between the environment_id and the event_id?

@chStaiger
Copy link
Member

@lagerweijgr
I checked the formatting of the synthetic data and the time notation I used there is recognised as string (object):

data['environment_events.csv']['event_time'][:2]

0    29:49
1    15:50
Name: event_time, dtype: object

How does your column look like when you print it?

@lagerweijgr
Copy link
Collaborator Author

@chStaiger
there is a logic between environment and environment_event. In my test data files there were environment_events however the ids used in this file where not present/filled in the "environment.csv"
Hence, it is about environment and not about "normal" event.csv

@lagerweijgr
Copy link
Collaborator Author

@chStaiger
About the event_time: I was looking at the event_time in the "host_event.csv" however the check is on event_time in "environment_event.csv" and in this file there is not time filled/present (and therefor the error is:
should be string, Found: float64 --- he is missing.

And the same for other missing columns that are not filled. Maybe an idea for next thursday; discuss which field can be empty and what to do with the check on this empty field/columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants