Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: consider usize for Encodable #11

Open
kilpatty opened this issue Jul 17, 2019 · 0 comments
Open

encoding: consider usize for Encodable #11

kilpatty opened this issue Jul 17, 2019 · 0 comments

Comments

@kilpatty
Copy link
Member

Right now we return a u32 for the Encodable trait's size function. While I don't think we will ever go over that size, Rust more commonly uses usize for this functionality. I think it would make sense for us to change the return value here so that the function works more smoothly with Rust's built in ones.

@kilpatty kilpatty changed the title encoding: consider size for Encodable encoding: consider usize for Encodable Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant