Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): choose correct root type name for the source #4571

Merged
merged 6 commits into from
Sep 24, 2022

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Sep 22, 2022

Fixes #4570

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 4984686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages
Name Type
@graphql-mesh/cli Patch
@graphql-mesh/grpc Patch
@graphql-mesh/http Patch
@graphql-mesh/runtime Patch
@graphql-mesh/container Patch
auth0-example Patch
cloudflare-workers Patch
graphql-file-upload-example Patch
grpc-example Patch
grpc-reflection-example Patch
hasura-openbrewery-geodb Patch
hello-world-esm Patch
json-schema-hello-world Patch
covid-mesh Patch
json-schema-example Patch
json-schema-fhir Patch
json-schema-subscriptions Patch
mongoose-example Patch
mysql-employees Patch
mysql-rfam Patch
neo4j-example Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
odata-microsoft-graph-example Patch
odata-msgraph-programmatic-ts Patch
odata-msgraph-programmatic Patch
odata-trippin-example Patch
javascript-wiki Patch
typescript-location-weather-example Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
postgres-geodb-example Patch
reddit-example Patch
country-info-example Patch
soap-demo Patch
soap-netsuite Patch
spacex-cfw Patch
chinook Patch
thrift-calculator Patch
type-merging-batching-example Patch
federation-gateway Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/cli 0.78.25-alpha-20220923124846-81d7eda14 npm ↗︎ unpkg ↗︎
@graphql-mesh/container 0.1.175-alpha-20220923124846-81d7eda14 npm ↗︎ unpkg ↗︎
@graphql-mesh/grpc 0.25.18-alpha-20220923124846-81d7eda14 npm ↗︎ unpkg ↗︎
@graphql-mesh/http 0.1.22-alpha-20220923124846-81d7eda14 npm ↗︎ unpkg ↗︎
@graphql-mesh/runtime 0.44.14-alpha-20220923124846-81d7eda14 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://9d4abbfc.graphql-mesh.pages.dev

@ardatan ardatan merged commit 1a8e808 into master Sep 24, 2022
@ardatan ardatan deleted the fix-source-root-type branch September 24, 2022 22:43
@Kinbaum
Copy link

Kinbaum commented Sep 26, 2022

@ardatan Thanks for this change. This works fine at runtime using the SDK, but still fails with the same error when running mesh dev

@ardatan
Copy link
Owner Author

ardatan commented Sep 26, 2022

@Kinbaum Could you create a new issue with a reproduction on CodeSandbox or StackBlitz?

@Kinbaum
Copy link

Kinbaum commented Sep 26, 2022

Nvm, sorry. Works fine. the mesh dev command doesn't use .mjs. Applied the fix to both index.js and index.mjs locally. All looks good to me, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to change the root Query type?
2 participants