Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for more border styles: double, groove, ridge, inset, outset #98

Closed
hrj opened this issue Feb 28, 2015 · 3 comments
Closed

Support for more border styles: double, groove, ridge, inset, outset #98

hrj opened this issue Feb 28, 2015 · 3 comments
Assignees
@PayalGodse
Labels
rendering
Milestone
0.4

Comments

@hrj
Copy link
Member

hrj commented Feb 28, 2015

No description provided.

@hrj hrj added the rendering label Feb 28, 2015
@hrj hrj added this to the 0.4 milestone Feb 28, 2015
@hrj
Copy link
Member Author

hrj commented Mar 23, 2015

Test case

PayalGodse pushed a commit to PayalGodse/gngr that referenced this issue Apr 1, 2015
for gngrOrg#98 adding diff file
f693a7d
hrj added a commit that referenced this issue Apr 1, 2015
@hrj
Merge pull request #104 from PayalGodse/i98_bstyles
60cf9d6 
for #98, more border styles
@hrj
Copy link
Member Author

hrj commented Jun 28, 2015

Was implemented in PR #104

Thanks @PayalGodse for your contribution. 👍

Let me know if there was something pending. Closing tentatively.

@hrj hrj closed this as completed Jun 28, 2015
@PayalGodse
Copy link
Contributor

There was some optimisation to be done considering the corners of borders.
and some cleaning of code...But main functionality is done.

Hope to contribute more in future :)

On Sun, Jun 28, 2015 at 12:08 AM, hrj [email protected] wrote:

Was implemented in PR #104 #104

Thanks @PayalGodse https://github.com/PayalGodse for your contribution. [image:
👍]

Let me know if there was something pending. Closing tentatively.

—
Reply to this email directly or view it on GitHub
#98 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PayalGodse PayalGodse

Labels
rendering
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@hrj @PayalGodse