Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback registry support to wally search #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Synthetic-Dev
Copy link

@Synthetic-Dev Synthetic-Dev commented Jun 11, 2022

Attempts to resolve #86

@Synthetic-Dev
Copy link
Author

Testing using my own index.
unknown-14.png

Need to test:

  • Circular fallback registries
  • Fallback chains longer than 2
  • Max depth flag for long chains

Possible addition:

  • Mark packages with the same scope/name in lower fallback registries as unavailable?

@magnalite
Copy link
Member

magnalite commented Jun 10, 2023

Great work! Sorry for taking so long to get back to this. PackageSourceMap already has logic for resolving the fallback chain which we can piggyback off here (PackageSourceMap.add_fallbacks()). The only issue is it presents this as a list of PackageSources. I suggest adding a method to PackageSource which allows us to send a request to the search backend of the registry and gives the raw response back. You'll want to ensure this branch is updated to the latest commit as PackageSource has been substantially redefined.

@Synthetic-Dev
Copy link
Author

Not had time to work on this. Someone feel free to pick it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fallback registry support to wally search
2 participants