-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of --locked #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u-train
force-pushed
the
implement-locked
branch
from
June 14, 2023 04:03
230ee45
to
32e8e0e
Compare
Initial implementation that works. Changed from --locked to better reflect its purpose. Right now, there are no tests in place.
- Testing is now complete - Locked works as intended now - Refactored common code into a utils module for subcommands
u-train
force-pushed
the
implement-locked
branch
from
June 15, 2023 02:42
32e8e0e
to
c10db32
Compare
Dekkonot
added
enhancement
New feature or request
rust
Pull requests that update Rust code
labels
Oct 31, 2024
Dekkonot
requested changes
Oct 31, 2024
it would not early exit if there was no change after writing such
Dekkonot
reviewed
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an entry in the changelog but otherwise it looks good to me.
Dekkonot
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 with an implementation
--locked
for install.