Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of --locked #119

Merged
merged 13 commits into from
Nov 3, 2024

Conversation

u-train
Copy link
Contributor

@u-train u-train commented Mar 19, 2023

Closes #5 with an implementation --locked for install.

Initial implementation that works.
Changed from --locked to better reflect its purpose.
Right now, there are no tests in place.
- Testing is now complete
- Locked works as intended now
- Refactored common code into a utils module for subcommands
@u-train u-train marked this pull request as ready for review June 15, 2023 02:44
@Dekkonot Dekkonot added enhancement New feature or request rust Pull requests that update Rust code labels Oct 31, 2024
src/commands/install.rs Show resolved Hide resolved
src/commands/install.rs Outdated Show resolved Hide resolved
src/commands/update.rs Outdated Show resolved Hide resolved
src/commands/utils.rs Outdated Show resolved Hide resolved
src/commands/install.rs Outdated Show resolved Hide resolved
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an entry in the changelog but otherwise it looks good to me.

Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dekkonot Dekkonot merged commit ffa2e76 into UpliftGames:main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement --locked argument for install command
2 participants