Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when plotting a model that hasn't been run #56

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

apulsipher
Copy link
Contributor

This pull request updates plot_epi.R to include a helpful error message when plotting a model before running the model.

It also updates relevant test cases.

@apulsipher apulsipher linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (c72336f) to head (9ac890a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   36.15%   36.21%   +0.06%     
==========================================
  Files          36       36              
  Lines        1975     1977       +2     
==========================================
+ Hits          714      716       +2     
  Misses       1261     1261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apulsipher apulsipher requested a review from gvegayon December 2, 2024 22:12
Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvegayon gvegayon merged commit 70f48d5 into main Dec 10, 2024
14 checks passed
@gvegayon gvegayon deleted the 39-helpful-plotting-error branch December 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return helpful error when plotting model before running model
2 participants