Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/less strict Python version #3193

Open
egeres opened this issue Jun 12, 2024 · 6 comments
Open

feat/less strict Python version #3193

egeres opened this issue Jun 12, 2024 · 6 comments
Labels
awaiting-response enhancement New feature or request

Comments

@egeres
Copy link

egeres commented Jun 12, 2024

Is your feature request related to a problem? Please describe.
Unstructured is using >=3.10,<3.13 (link), I think in the long term it would be better to use >=3.10,<4.0. This also matches with Langchain's Python version, which is currently set to >=3.10,<4.0 (link), so when using unstructured for document loading within Langchain both packages are easier to set up

Describe the solution you'd like
Switch the python_requires=">=3.9.0,<3.13" in setup.py to use >=3.10,<4.0

@egeres egeres added the enhancement New feature or request label Jun 12, 2024
@egeres egeres changed the title feat/less strint Python version feat/less strict Python version Jun 12, 2024
@MthwRobinson
Copy link
Contributor

@egeres - Is this causing installation issues for you or anything like that? I'd be okay with this update, though we only test up to Python 3.12 in CI, so any later versions would be "use at your own risk".

@scanny
Copy link
Collaborator

scanny commented Jun 12, 2024

Given the number of third-party dependencies and the non-trivial nature of supporting a newer Python version, I'd be inclined to limit folks to the latest version we know works with all the dependencies.

Problems encountered when we go to add support for a new Python version have always been related to third-party package dependencies, not the unstructured code itself. If we lead folks to believe they can get a clean install with a new version and then that fails because of a pip error, I'd say it was on us for not letting them know up front.

@egeres
Copy link
Author

egeres commented Jun 13, 2024

@MthwRobinson nothing critical, it was a tiny hassle with langchain because I had to change my package version to >=3.13,<4.0. Generally speaking I have seen more packages setting the bounds to >=3.10,<4.0 than otherwise, but the idea of being cautious as @scanny says seems reasonable as well

@MthwRobinson
Copy link
Contributor

Going to close this out and we'll keep this as is (keeping the upper bound on the Python version explicit). We can revisit this though if the stricter range becomes a problem for people.

@TheTechromancer
Copy link

This has recently become an issue for us as we are trying to add support for python 3.13.

@lucasgadams
Copy link

This is an issue for us. @scanny I also disagree that it is your responsibility to put a hard limit on the allowed versions of python because you suspect there could be an issue with a higher version in a 3rd party package. That would be the responsibility of those 3rd party packages.

@scanny scanny reopened this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants