Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create way to trigger "merge when ready" without admin intervention #1676

Closed
ryannikolaidis opened this issue Oct 6, 2023 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ryannikolaidis
Copy link
Contributor

Is your feature request related to a problem? Please describe.
With merge queues enabled, now an admin must be the one to trigger the "Merge when ready" button on a PR, in order to add it to the merge queue.

Describe the solution you'd like
Ideally if a PR has been approved that should be sufficient to allow merging or rather "adding to the queue to merge". It doesn't seem this is exposed as an option in GH repo settings.

Describe alternatives you've considered
Potentially this could be done with a bot or possibly a workflow trigger?

Additional context
It looks like we can add to the merge queue via the github cli. Basically if merge queue is required/enabled gh pr merge will add it to the queue rather than merging. This could be leveraged for either of the proposed options.

@ryannikolaidis ryannikolaidis added the enhancement New feature or request label Oct 6, 2023
@tabossert tabossert self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants