Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill monero-wallet-rpc process on exit #21

Closed
binarybaron opened this issue Aug 9, 2024 · 2 comments
Closed

Kill monero-wallet-rpc process on exit #21

binarybaron opened this issue Aug 9, 2024 · 2 comments
Labels
enhancement New feature or request GUI Related to the Tauri GUI

Comments

@binarybaron
Copy link

binarybaron commented Aug 9, 2024 •
edited
Loading

We need to kill the monero-wallet-rpc process if the GUI exits. Otherwise it can become orhphaned which will prevent us from opening the wallet again later.

See this PR for more information: comit-network#1434

https://docs.rs/tauri/latest/tauri/struct.App.html#method.run
@binarybaron binarybaron added the enhancement New feature or request label Aug 9, 2024
@binarybaron binarybaron transferred this issue from another repository Aug 17, 2024
@binarybaron binarybaron added the GUI Related to the Tauri GUI label Aug 17, 2024
@binarybaron
Copy link
Author

binarybaron commented Sep 9, 2024 •
edited
Loading

If the app exits gracefully it is killed. If we crash however it is not. I don't know if there's anything we can do about this.

@binarybaron binarybaron mentioned this issue Oct 13, 2024
Open
@binarybaron
Copy link
Author

Closed by #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request GUI Related to the Tauri GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarybaron