Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Monero inputs efficiently #120

Open
darkness-su opened this issue Oct 15, 2024 · 1 comment
Open

Manage Monero inputs efficiently #120

darkness-su opened this issue Oct 15, 2024 · 1 comment
Labels
asb Related to the ASB (maker side) enhancement New feature or request

Comments

@darkness-su
Copy link

darkness-su commented Oct 15, 2024

Currently, asb seems to take any 2 or more inputs present in the wallet for transactions. This results in inputs being jumbled together into one unnecessarily and getting progressively bigger, which reduces available liquidity for swaps during ongoing swaps and can even cause unavailability of the provider during swaps once only one input is left.

For example, refilling xmr.darkness.su with exclusively 10 XMR inputs:
image

Current state of inputs (Primary address inputs are recent conversions back to XMR):
image

The asb server should only use one input, preferably the smallest one it can use for the ongoing swap, in order to maintain the highest possible available liquidity for further swaps. Only if no one input is big enough for the amount being swapped, should multiple inputs be used, again using as few and as small as possible.

@binarybaron
Copy link

This is handled by the monero-wallet-rpc which default to always creating 2-to-2 transactions (2 inputs, 2 outputs) to minimize fingerprinting attacks.

But I see your point. I'll think about what we can do here.

@binarybaron binarybaron added enhancement New feature or request asb Related to the ASB (maker side) labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asb Related to the ASB (maker side) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants