python3 support for scd30.py, wiring example, root comment for installing clock stretching and more Readme. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servetcoskun
changed the title
species
reviewed
Mar 18, 2019
| float_T = struct.unpack('>f', struct_T) | ||
|
|
||
| struct_rH = struct.pack('>BBBB', data[12], data[13], data[15], data[16]) | ||
| float_rH = struct.unpack('>f', struct_rH)[0] |
There was a problem hiding this comment.
why did you add [0] for float_co2 and float_rH, but not for float_T - is there any difference?
There was a problem hiding this comment.
I will test, but I think it was because the co2 and rh returned a list while the temperature returned a single value.
There was a problem hiding this comment.
Hm - the data format is exactly the same for all three... and struct.unpack('>f', ... ) should return a single float every time...
There was a problem hiding this comment.
Yes that makes sense, I will have time to test today and will put the output of the code here later.
There was a problem hiding this comment.
There should definitely be a [0] for temperature as well, you are right :)
struct_co2 = struct.pack('>BBBB', data[0], data[1], data[3], data[4])
float_co2 = struct.unpack('>f', struct_co2)[0]
struct_T = struct.pack('>BBBB', data[6], data[7], data[9], data[10])
float_T = struct.unpack('>f', struct_T)[0]
struct_rH = struct.pack('>BBBB', data[12], data[13], data[15], data[16])
float_rH = struct.unpack('>f', struct_rH)[0]
that is the correct way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.