-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade v2-mst-aptd-at-lcz-sty
preset to Next.js 10
#189
Conversation
❌ Deployment FAILED |
❌ Deployment FAILED |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit a5c140e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-2t5p4xr46.vercel.app |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit a9df25e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-ocogpdpcc.vercel.app |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit 6838ed3 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-aydh0quhd.vercel.app |
…al types directly)
…the Emotion "css" props (@emotion/babel-preset-css-prop) - See vercel/next.js#18461 (comment)
6838ed3
to
b121bbb
Compare
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit b121bbb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit b121bbb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app |
Goal:
Upgrade the
v2-mst-aptd-at-lcz-sty
preset to Next.js 10. See https://nextjs.org/blog/next-10Once it's ready for
v2-mst-aptd-at-lcz-sty
, changes will be ported tov2-mst-aptd-gcms-lcz-sty
preset.Major deps updates:
Encountered issues:
react@latest react-dom@latest
crashes withpragma and pragmaFrag cannot be set when runtime is automatic.
pragma has been set but pragmaFrag has not been set
vercel/next.js#18461 (comment) did workNon-backward compatible changes:
/** @jsx jsx */
anymore, because doing so isn't compatible with the new babelautomatic
JSX Transform./** @jsxFrag React.Fragment */
(NRN didn't use it, but you might)jsx
from'@emotion/core'
are to be removed (unused)Noticeable changes:
babel.config.js
file had to be added, to provide support of the newautomatic
JSX Transform with EmotionResources: