Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v2-mst-aptd-at-lcz-sty preset to Next.js 10 #189

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Oct 29, 2020

Goal:

Upgrade the v2-mst-aptd-at-lcz-sty preset to Next.js 10. See https://nextjs.org/blog/next-10

Once it's ready for v2-mst-aptd-at-lcz-sty, changes will be ported to v2-mst-aptd-gcms-lcz-sty preset.

Major deps updates:

  • Next 9 > 10.0.0
  • React 16 > 17

Encountered issues:

Non-backward compatible changes:

  • It is not possible to use the JSX pragma /** @jsx jsx */ anymore, because doing so isn't compatible with the new babel automatic JSX Transform.
    • Same goes for /** @jsxFrag React.Fragment */ (NRN didn't use it, but you might)
    • Also, all references of jsx from '@emotion/core' are to be removed (unused)
    • Overall, that's a good news, less boilerplate code to use Emotion.

Noticeable changes:

Resources:

@Vadorequest Vadorequest marked this pull request as draft October 29, 2020 10:20
@Vadorequest Vadorequest linked an issue Oct 29, 2020 that may be closed by this pull request
@Vadorequest Vadorequest added the enhancement New feature or request label Oct 29, 2020
@Vadorequest Vadorequest self-assigned this Oct 29, 2020
@github-actions
Copy link

❌  Deployment FAILED
Commit a7cb72f failed to deploy to
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit c353b29 failed to deploy to
click to see logs

@github-actions
Copy link

✅  Deployment SUCCESS
Commit a5c140e successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-2t5p4xr46.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit a5c140e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-2t5p4xr46.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit a9df25e successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ocogpdpcc.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit a9df25e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-ocogpdpcc.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 6838ed3 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-aydh0quhd.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 6838ed3 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-aydh0quhd.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b121bbb successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review October 30, 2020 07:50
@github-actions
Copy link

✅  E2E tests SUCCESS for commit b121bbb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app

@Vadorequest Vadorequest merged commit 129a4ae into v2-mst-aptd-at-lcz-sty Oct 30, 2020
@Vadorequest Vadorequest deleted the upgrade-next10 branch October 30, 2020 07:50
@Vadorequest Vadorequest mentioned this pull request Oct 30, 2020
@Vadorequest Vadorequest restored the upgrade-next10 branch October 30, 2020 07:55
@github-actions
Copy link

✅  Deployment SUCCESS
Commit b121bbb successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-upgrade-nex.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit b121bbb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6ybeagfmh.vercel.app

@Vadorequest Vadorequest deleted the upgrade-next10 branch January 17, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 10
1 participant