chore: add migration for traffic data collection #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
daveleek
commented
Feb 8, 2024
| ` | ||
| CREATE TABLE IF NOT EXISTS stat_traffic_usage( | ||
| day DATE NOT NULL, | ||
| traffic_group TEXT NOT NULL, |
There was a problem hiding this comment.
ended up naming this traffic_group as the group name we initially came up with was a reserved keyword in Postgresql
daveleek
commented
Feb 8, 2024
| CREATE TABLE IF NOT EXISTS stat_traffic_usage( | ||
| day DATE NOT NULL, | ||
| traffic_group TEXT NOT NULL, | ||
| status_code_series INT NOT NULL, |
There was a problem hiding this comment.
appended a _series to make it clear that it's 200/300 etc, not 200/201/202/304 etc
|
@gardleopard , @sjaanus do you think this would do for storing 400 days of data for visitation stats? |
|
I think creating subindexes on day, traffic_group and status_code_series could help. the PK index will be a thruple of (day, tg, scs), so if we want to do where status_code_series = 200 it will be a table scan. |
|
Thanks @chriswk - I've added the suggested indexes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds migration for creating table
stat_traffic_usage.This table primary-keys on day, traffic_group, and status_code_series.
Traffic group is the grouping for API endpoints for which traffic is counted.
status_code_series is 200/202 etc = 200, 304 etc = 300