Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset selected toggle after archive or revive #4606

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Sep 4, 2023

About the changes

When archiving or reviving feature toggles, when toggles disappear from table, actions bar should also disappear.

Closes https://linear.app/unleash/issue/1-1293/bulk-revive-modal-doesnt-go-away

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 4:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Sep 4, 2023 4:34pm

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I'm wondering how difficult would it be to show with a RTL test that we had a bug and not that it's gone.

@Tymek Tymek merged commit c19bd61 into main Sep 5, 2023
4 of 6 checks passed
@Tymek Tymek deleted the 1-1293-bulk-revive-modal-doesnt-go-away branch September 5, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants