From 34e917f0ee29b0091d7848f9f5e42272b71ae467 Mon Sep 17 00:00:00 2001 From: andreas-unleash Date: Fri, 12 Apr 2024 14:22:53 +0300 Subject: [PATCH] fix: Insights placement in drawer nav (#6846) Moves the Insights nav menu item down to match desktop ordering Closes # [1-2290](https://linear.app/unleash/issue/1-2290/mobile-menu-insights-pops-up-as-the-first-item) Screenshot 2024-04-12 at 13 12 25 --------- Signed-off-by: andreas-unleash --- .../__snapshots__/routes.test.tsx.snap | 22 +++++++++---------- frontend/src/component/menu/routes.ts | 22 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap b/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap index 7913e62e581f..04c2d79d0276 100644 --- a/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap +++ b/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap @@ -10,17 +10,6 @@ exports[`returns all baseRoutes 1`] = ` "title": "Unleash", "type": "protected", }, - { - "component": [Function], - "enterprise": false, - "flag": "executiveDashboardUI", - "menu": { - "mobile": true, - }, - "path": "/insights", - "title": "Insights", - "type": "protected", - }, { "component": { "$$typeof": Symbol(react.lazy), @@ -151,6 +140,17 @@ exports[`returns all baseRoutes 1`] = ` "title": "Playground", "type": "protected", }, + { + "component": [Function], + "enterprise": false, + "flag": "executiveDashboardUI", + "menu": { + "mobile": true, + }, + "path": "/insights", + "title": "Insights", + "type": "protected", + }, { "component": [Function], "menu": {}, diff --git a/frontend/src/component/menu/routes.ts b/frontend/src/component/menu/routes.ts index af20930a54a0..3a809b7367bc 100644 --- a/frontend/src/component/menu/routes.ts +++ b/frontend/src/component/menu/routes.ts @@ -60,17 +60,6 @@ export const routes: IRoute[] = [ isStandalone: true, }, - // Insights - previously "Executive dashboard" - { - path: '/insights', - title: 'Insights', - component: Insights, - type: 'protected', - menu: { mobile: true }, - flag: 'executiveDashboardUI', - enterprise: false, - }, - // Project { path: '/projects/create', @@ -173,6 +162,17 @@ export const routes: IRoute[] = [ menu: { mobile: true }, }, + // Insights + { + path: '/insights', + title: 'Insights', + component: Insights, + type: 'protected', + menu: { mobile: true }, + flag: 'executiveDashboardUI', + enterprise: false, + }, + // Applications { path: '/applications/:name/*',