Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More informative warn logs #35

Open
skairunner opened this issue May 31, 2022 · 2 comments · May be fixed by #36 or #65
Open

More informative warn logs #35

skairunner opened this issue May 31, 2022 · 2 comments · May be fixed by #36 or #65
Labels
enhancement New feature or request

Comments

@skairunner
Copy link

Describe the feature request

In poll_for_updates, errors are consumed and a fixed log message is printed instead. For example, if the HTTP request fails it simply prints warn!("poll: failed to retrieve features"). This is unhelpful for debugging. It'd be helpful to print the particulars of the error.

Background

I am currently attempting to use unleash-api-client in a cloud-hosted project. It has started sporadically failing, but without information on the particulars I can't easily debug it.

Solution suggestions

It'd be a case-by-case basis, but generally would just need to include a debug-formatted version of the originating error.
@skairunner skairunner added the enhancement New feature or request label May 31, 2022
@skairunner skairunner linked a pull request May 31, 2022 that will close this issue
Open
@thomasheartman
Copy link
Contributor

Hey, @skairunner 👋🏼 Thanks for the request and thanks for the proposed changes too ☺️ That sounds like a great suggestion to me, so I'm all for it! But I'll need to align with the rest of the team internally. We should be able to get back to with some more info some time tomorrow at latest, I think. Is that alright? 😄

@skairunner
Copy link
Author

Sounds good to me!

@thomasheartman thomasheartman moved this from New to In Progress in Issues and PRs Jun 1, 2022
@sighphyre sighphyre moved this from In Progress to For later in Issues and PRs Jun 29, 2022
@sighphyre sighphyre moved this from For later to Done in Issues and PRs Jun 29, 2022
@Meemaw Meemaw linked a pull request Jul 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@skairunner @thomasheartman