Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid manifest crashes universalviewer.io #317

Closed
jcoyne opened this issue May 12, 2016 · 3 comments
Closed

Valid manifest crashes universalviewer.io #317

jcoyne opened this issue May 12, 2016 · 3 comments
Assignees
Labels

Comments

@jcoyne
Copy link

jcoyne commented May 12, 2016

When I put this url in the field: https://gist.githubusercontent.com/jcoyne/78db6cfb554d6c5b120c39260ea609f5/raw/6ee86534f2208f32cdc9522b8cf2dccd3b0f3582/manifest.json and click "Open"

Nothing displays and I see this in the console: TypeError: p is undefined

screen shot 2016-05-12 at 3 10 19 pm

The IIIF validator thinks this is valid though.

http://iiif.io/api/presentation/validator/service/validate?url=https%3A%2F%2Fgist.githubusercontent.com%2Fjcoyne%2F78db6cfb554d6c5b120c39260ea609f5%2Fraw%2F6ee86534f2208f32cdc9522b8cf2dccd3b0f3582%2Fmanifest.json&version=2.0&format=html

@jcoyne
Copy link
Author

jcoyne commented May 13, 2016

I think this is because the manifest didn't have a service. When I added one it gets past this error. It might be a good idea to trap for this error and log something more user friendly.

@edsilv edsilv added the bug label May 23, 2016
@edsilv edsilv self-assigned this May 23, 2016
@edsilv
Copy link
Member

edsilv commented May 26, 2016

Yep, this was a problem in manifesto (the base IIIF utils lib that the UV uses). I've altered it so that if it can't find the image service it returns the thumbnail or null, but doesn't error out:

https://github.com/UniversalViewer/manifesto/blob/dev/src/Canvas.ts#L48

The problem then is that without the image service OpenSeadragon can't find the tiles. This shows a user-friendly error though.

Here's an example of a working level 0 manifest for reference:

https://ipfs.io/ipfs/QmYomyCpT1vKNovYvTjAStYq31JoaH8xdivjmWcDj5mpM1

@edsilv edsilv closed this as completed May 26, 2016
@jcoyne
Copy link
Author

jcoyne commented May 26, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants