Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the resources folder instead of the script file directly #62

Merged
merged 1 commit into from
May 6, 2021

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented May 6, 2021

The main problem before was that the resource file got installed into another
relative package location (/) than in the source package (/resources).
This way, other packages searching that file would not work with both, source
builds and installed versions.

The main problem before was that the resource file got installed into another
relative package location (/) than in the source package (/resources).
This way, other packages searching that file would not work with both, source
builds and installed versions.
@fmauch
Copy link
Collaborator Author

fmauch commented May 6, 2021

Merging although noetic pipeline is failing in downstream workspace setup. Melodic and foxy are running fine.

@fmauch fmauch merged commit 76714d7 into UniversalRobots:master May 6, 2021
@fmauch fmauch deleted the fix_install_path_script branch May 6, 2021 19:50
urmahp pushed a commit to urmahp/Universal_Robots_Client_Library that referenced this pull request Sep 5, 2022
…versalRobots#62)

The main problem before was that the resource file got installed into another
relative package location (/) than in the source package (/resources).
This way, other packages searching that file would not work with both, source
builds and installed versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant