Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UR30 in start_ursim.sh #193

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Dec 22, 2023

Resolves #192

I'll make this a draft for now, as there is no docker image supporting the UR30 available at the moment.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (914e68c) 72.09% compared to head (54c23c2) 72.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files          71       71           
  Lines        2652     2652           
  Branches      337      337           
=======================================
  Hits         1912     1912           
  Misses        554      554           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A docker image supporting UR30 ursim has been released, so this can be merged now.

@fmauch fmauch marked this pull request as ready for review February 15, 2024 21:11
@fmauch fmauch merged commit 04725c1 into UniversalRobots:master Feb 15, 2024
17 of 19 checks passed
@fmauch fmauch deleted the ur30 branch February 15, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UR30
2 participants