Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make depreaction warning for keepalive_counter a warning instead of error #182

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Sep 22, 2023

As suggested in #180

I overlooked that when reviewing #178, but noticed that when starting a driver built against the newest version.

@fmauch fmauch requested a review from urmahp September 22, 2023 10:00
@fmauch fmauch added this to the Release 1.3.4 milestone Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/ur/ur_driver.cpp 0.00%

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with making it a warning.

@fmauch fmauch merged commit 9161d6b into UniversalRobots:master Sep 22, 2023
17 of 19 checks passed
@fmauch fmauch deleted the fix_deprecation_warning branch September 22, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants