Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throws exception if the URScript file doesn't exists #173

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Throws exception if the URScript file doesn't exists #173

merged 3 commits into from
Aug 31, 2023

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Aug 30, 2023

This will fix #142

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
include/ur_client_library/ur/ur_driver.h ø
src/ur/ur_driver.cpp 100.00%

📢 Thoughts on this report? Let us know!.

@urrsk
Copy link
Member

urrsk commented Aug 30, 2023

Please add unit tests

fmauch
fmauch approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you also for implementing the unit test for this.

@fmauch fmauch merged commit cb9c7f3 into UniversalRobots:master Aug 31, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urrsk urrsk urrsk approved these changes

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninformative error when script file does not exist
3 participants
@urmahp @urrsk @fmauch