-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RTDEClient constructor with vector recipes #143
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 70.21% 70.35% +0.14%
==========================================
Files 69 69
Lines 2535 2547 +12
Branches 324 324
==========================================
+ Hits 1780 1792 +12
Misses 568 568
Partials 187 187
☔ View full report in Codecov by Sentry. |
@dagare Thanks for this good suggestion. |
I will make a new addition to this PR |
4b7718a
to
0c9c40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagare Thank you for the contribution. Could you please provide some insight why you see this as beneficial?
I'm considering to suggest only allow passing recipes to the RTDEClient
class as vectors directly, so parsing a file (if any) would have to be done a level higher up.
@RobertWilbrandt what do you think?
Agreed, i think moving the file handling out of |
0c9c40e
to
b5c4bd1
Compare
I will suggest we add the support first. |
b5c4bd1
to
5d7c308
Compare
5d7c308
to
709dfe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dagare for the contribution.
I have added a small adjustment, but other than that it looks good.
Before merging I suggest that we add checks in the constructor to see if the recipes are empty and whether "timestamp" is part of the output_recipe. |
8c3817f
to
34175cb
Compare
cfdf00a
to
65db944
Compare
Thank you for the contribution @dagare. |
No description provided.