Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the rtde interface clasess #125

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Oct 24, 2022

This adds tests for

  • control package pause
  • control package start
  • control package setup outputs
  • control package setup inputs
  • get urcontrol version
  • request protocol version
  • rtde writer

Added more tests to

  • test_rtde_data_package
  • test_rtde_parser
  • test_rtde_client

Added functionality to rtde_client

  • get_target_frequency function and warning when it is not possible to set target frequency
  • Read timeout in isRobotBooted is now based on target frequency
  • Added a wait on 5 seconds to receive answer from pause request. This will prevent the driver from crashing once in a while when pausing the rtde client

Added functionality for rtde_writer

  • Added checks for values and pins before sending to the robot
  • Removed unnecessary sleep in desctructor

Added pipeline changes, so that the test output is shown in the pipeline in case of failure

This adds tests for
* control package pause
* control package start
* control package setup outputs
* control package setup inputs
* get urcontrol version
* request protocol version
* rtde writer

Added more tests to
* test_rtde_data_package
* test_rtde_parser
* test_rtde_client

Added functionality to rtde_client
* get_target_frequency function and warning when it is not possible to set target frequency
* Read timeout in isRobotBooted is now based on target frequency
* Added a wait on 5 seconds to receive answer from pause request. This will prevent the driver from crashing once in a while when pausing the rtde client

Added functionality for rtde_writer
* Added checks for values and pins before sending to the robot
* Removed unnecessary sleep in desctructor

Added pipeline changes, so that the test output is shown in the pipeline in case of failure
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 51.21% // Head: 63.40% // Increases project coverage by +12.19% 🎉

Coverage data is based on head (c5d853c) compared to base (1d9b975).
Patch coverage: 90.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #125       +/-   ##
===========================================
+ Coverage   51.21%   63.40%   +12.19%     
===========================================
  Files          82       89        +7     
  Lines        2466     2968      +502     
  Branches      279      310       +31     
===========================================
+ Hits         1263     1882      +619     
+ Misses       1072      925      -147     
- Partials      131      161       +30     
Impacted Files Coverage Δ
include/ur_client_library/rtde/rtde_writer.h 80.00% <ø> (-20.00%) ⬇️
src/rtde/rtde_client.cpp 55.82% <44.44%> (+11.71%) ⬆️
tests/test_rtde_parser.cpp 83.90% <75.86%> (-12.97%) ⬇️
tests/test_rtde_client.cpp 81.52% <81.60%> (-13.22%) ⬇️
src/rtde/rtde_writer.cpp 79.62% <87.23%> (+67.34%) ⬆️
tests/test_rtde_writer.cpp 93.57% <93.57%> (ø)
include/ur_client_library/rtde/rtde_client.h 100.00% <100.00%> (+100.00%) ⬆️
tests/test_rtde_control_package_pause.cpp 100.00% <100.00%> (ø)
tests/test_rtde_control_package_setup_inputs.cpp 100.00% <100.00%> (ø)
tests/test_rtde_control_package_setup_outputs.cpp 100.00% <100.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
@fmauch fmauch merged commit 1ed6576 into UniversalRobots:master Oct 25, 2022
@urmahp urmahp deleted the rtde_interface_tests branch October 31, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants