Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(samsung): add packages #743

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

YoshiiShell
Copy link

Add the packages:
com.samsung.android.callassistant
com.monotype.android.font.roboto
com.samsung.slsi.telephony.silentlogging
com.google.android.photopicker

Copy link
Contributor

deepsource-io bot commented Nov 26, 2024

Here's the code health analysis summary for commits 88d9464..c9d15eb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP changed the title pkg(samsung): Add packages pkg(samsung): add packages Nov 26, 2024
@AnonymousWP AnonymousWP added the package::addition Adding new apps to the debloat list label Nov 26, 2024
@AnonymousWP AnonymousWP requested a review from a team November 26, 2024 08:40
@AnonymousWP AnonymousWP reopened this Nov 26, 2024
@AnonymousWP
Copy link
Member

@YoshiiShell You can just push new commits to this branch/PR, no need to open a new one.

@YoshiiShell YoshiiShell reopened this Nov 26, 2024
@AnonymousWP
Copy link
Member

Another error:

thread 'core::uad_lists::tests::test_parse_json' panicked at src/core/uad_lists.rs:243:60:
Unable to parse: Error("expected `,` or `}`", line: 10567, column: 3)

@schbrns
Copy link
Contributor

schbrns commented Nov 26, 2024

Thanks, I'll review this tomorrow. Need to check my One UI file so I can merge mine in too.

@schbrns
Copy link
Contributor

schbrns commented Nov 26, 2024

@YoshiiShell If you have time, could you submit Google as one PR and font (should be Aosp) as another? This PR's pkg scope is samsung. Thanks.

@YoshiiShell
Copy link
Author

@YoshiiShell If you have time, could you submit Google as one PR and font (should be Aosp) as another? This PR's pkg scope is samsung. Thanks.

Yeah working on that rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::addition Adding new apps to the debloat list
Projects
None yet
3 participants