Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concurrency issue #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irgendwr
Copy link
Contributor

@irgendwr irgendwr commented Feb 9, 2019

fixes #21

Blendman974
Blendman974 previously approved these changes Feb 9, 2019
client.go Show resolved Hide resolved
client_test.go Outdated Show resolved Hide resolved
client_test.go Outdated Show resolved Hide resolved
client_test.go Outdated Show resolved Hide resolved
@@ -234,7 +236,15 @@ func (c *Client) ExecCmd(cmd *Cmd) ([]string, error) {
return nil, ErrNotConnected
}

c.work <- cmd.String()
c.mutex.Lock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in too minds if we want to do this, it adds the lock overhead to a client which can only perform one request at a time. This falls under the remit of nothing being concurrent safe unless documented to be so.

Copy link
Contributor Author

@irgendwr irgendwr Feb 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to think of a better solution to solve this but it should definitely be concurrent safe imho (the fact that two people reported the issue suggests that it's expected despite not being "documented to be so").
Is the tiny overhead really that significant in this use case?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue doesn't come from trying to use the library from multiple goroutines at once.

My issue happens once unhandled timeout/connection closed errors occur. (for example: read: connection reset by peer)

Because the next time I execute a command on that closed connection, the conn.Write() call freezes indefinitely, causing the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabling keepalive on the connection should fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conn.Write() should also never freeze "indefinitely", only as long as the Timeout that is specified/DefaultTimout, since there's a Deadline set before calling it.

client_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezing in go routine
4 participants