Fix incorrect IR for expression with two ternary operators #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaMuravjov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## neo #220 +/- ##
============================================
- Coverage 59.91% 59.80% -0.12%
+ Complexity 2417 2416 -1
============================================
Files 294 294
Lines 18469 18469
Branches 3306 3306
============================================
- Hits 11066 11045 -21
- Misses 6328 6346 +18
- Partials 1075 1078 +3 ☔ View full report in Codecov by Sentry. |
IlyaMuravjov
force-pushed
the
ilya_m/two-ternary-operators
branch
from
4214090 to
59a7466
Compare
Saloed
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
Doesn't pass
UnusedVariableTest, which seems to be less bad when compared to producing incorrect IR