Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize the init code hash #917

Merged
merged 2 commits into from
Nov 8, 2024
Merged

standardize the init code hash #917

merged 2 commits into from
Nov 8, 2024

Conversation

vimageDE
Copy link
Collaborator

@vimageDE vimageDE commented Nov 8, 2024

Related Issue

The init code hash of the PoolManager.sol in v4-core and v4-periphery was different because of different paths inside the metadata. This PR will disable the inclusion of the metadata hash inside of the compiled bytecode.

Description of changes

Setting bytecode_hash = "none" in foundry.toml.

@vimageDE vimageDE requested a review from a team as a code owner November 8, 2024 14:18
hensha256
hensha256 previously approved these changes Nov 8, 2024
@hensha256 hensha256 enabled auto-merge (squash) November 8, 2024 14:34
@hensha256 hensha256 merged commit b619b67 into main Nov 8, 2024
5 checks passed
@hensha256 hensha256 deleted the disable-metadata-hash branch November 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants