Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #812: revert only if > max price #813

Closed
wants to merge 2 commits into from

Conversation

wjmelements
Copy link
Contributor

Reviewers @hensha256 @snreynolds
Fixes #812
This makes both price boundaries inclusive.
Currently one is inclusive and the other is exclusive.

Changes

  • revert only if > max price

@wjmelements wjmelements changed the title Fix #812 Fix #812: revert only if > max price Jul 31, 2024
@hensha256
Copy link
Contributor

This is purposeful :)
max price is not achievable by design

@hensha256 hensha256 closed this Aug 1, 2024
@wjmelements
Copy link
Contributor Author

e9958fd would similarly improve consistency

wjmelements referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

price boundary discrepancy: MIN_SQRT_PRICE is inclusive but MAX_SQRT_PRICE is exclusive
2 participants