Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: not using removeOverrideAndValidate which is used in Pool.sol in PoolTest #684

Closed
zhongeric opened this issue May 22, 2024 · 2 comments

Comments

@zhongeric
Copy link
Contributor

        // TODO: consider why not using removeOverrideAndValidate which is used in Pool.sol

uint24 _lpFee = params.lpFeeOverride.isOverride() ? params.lpFeeOverride.removeOverrideFlag() : lpFee;

@hensha256
Copy link
Contributor

We dont use that method in the test because it would cause an uncaught revert in the test - we want to execute swap with the invalid lp fee, and check that swap still reverts when that happens. That is caught in an if statement later in the test
} else if (!swapFee.isValid()) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants