Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pragma to solidity 0.8.24 #478

Closed
2 tasks
saucepoint opened this issue Feb 12, 2024 · 0 comments · Fixed by #479
Closed
2 tasks

Set pragma to solidity 0.8.24 #478

saucepoint opened this issue Feb 12, 2024 · 0 comments · Fixed by #479
Assignees
Labels

Comments

@saucepoint
Copy link
Collaborator

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

With #473 replacing the custom solc in favor of 0.8.24, foundry will not default to 0.8.24 until it compiles at least once with some version hint (i.e. in foundry.toml or a file with pragma 0.8.24)

Afterwards, it should default to 0.8.24. in its current state, its annoying to have to manually nudge it

Describe the desired implementation.

  • pin solc = "0.8.24" in foundry.toml
  • Update any file that touches or is related to Lockers.sol. For other files, i.e. SwapMath can probably stay unchanged

Describe alternatives.

N/A

Additional context.

N/A

@saucepoint saucepoint self-assigned this Feb 12, 2024
@saucepoint saucepoint mentioned this issue Feb 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant