You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Singleton, 1155 Balances, Pool Actions (swap, modifyPosition, donate, take, settle, mint), Gas Optimization, General design optimization (improving efficiency, cleanliness, or developer experience)
Describe the suggested feature and problem it solves.
The current interface for multi-token accounting is ERC-1155, which contains constraints for unnecessary callbacks, unnecessary batching, and all-or-nothing transfer delegation. Replacing ERC-1155 with ERC-6909 reduces code size, improves the transfer delegation system, and improves gas efficiency for deployment, transfers, and burning.
Describe the desired implementation.
Replace ERC-1155 with ERC-6909 in the inheritance tree, replace the callback-based burn mechanism with a single burn function, and remove the ERC1155Receiver interface.
Describe alternatives.
The ERC-6909 interface does constrain a total supply variable, leading to an additional disk write on mint and burn.
Additional context.
No response
The text was updated successfully, but these errors were encountered:
Thanks for the contribution @jtriley-eth . Tagging this as p0 for our team to compare this impl to some other ideas we have. We are weighing this against a custom ERC-1155 solution vs. just keeping the original ERC1155 impl .
We're actively exploring how we can work towards a standard (either 6909 in particular or 6909-like), and so let's keep this issue open and reference it in any future PRs / work on this front
Component
Singleton, 1155 Balances, Pool Actions (swap, modifyPosition, donate, take, settle, mint), Gas Optimization, General design optimization (improving efficiency, cleanliness, or developer experience)
Describe the suggested feature and problem it solves.
The current interface for multi-token accounting is ERC-1155, which contains constraints for unnecessary callbacks, unnecessary batching, and all-or-nothing transfer delegation. Replacing ERC-1155 with ERC-6909 reduces code size, improves the transfer delegation system, and improves gas efficiency for deployment, transfers, and burning.
Describe the desired implementation.
Replace ERC-1155 with ERC-6909 in the inheritance tree, replace the callback-based burn mechanism with a single burn function, and remove the ERC1155Receiver interface.
Describe alternatives.
The ERC-6909 interface does constrain a total supply variable, leading to an additional disk write on mint and burn.
Additional context.
No response
The text was updated successfully, but these errors were encountered: