Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify methods of rewriting event properties to match zino 1 protocol. #338

Open
runborg opened this issue Aug 2, 2024 · 2 comments
Open
Assignees

Comments

@runborg
Copy link

runborg commented Aug 2, 2024

There are now two ways that event property-names are modified to match the zino 1 protocol names. the first one is a catch-all rewrite of underscore to dashes: 7caf880#diff-5eef89ad67750f4ac6ef25ea411553bf2bc5dab2d901020b7526ab52b774bf3b

and the new one is using aliasses in pydantic to create custom names as done here: #335

as there is also some case-sensitive property-names the first implementation does not fit all modifications, that should be removed and add pydantic aliasses to all properties that need a rewrite instead.

as for now it seems to be these elements needing to be rewritten to pydantic aliasses:

BGP:

  • remote_addr: Optional[IPAddress] = None
  • peer_uptime: Optional[int] = None

Alarm:

  • alarm_type: Optional[AlarmType] = None
  • alarm_count: Optional[int] = None
@johannaengland
Copy link
Contributor

This issue merits a meeting about all the event/pm attribute names, to generally having better/more descriptive names and then adding the Zino1 names as alias.

@lunkwill42
Copy link
Member

This is related to #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants