-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a BFDTrapObserver
#305
Conversation
This makes `BFDTask` able to fetch and update the BFD state of a single session, by adding a `session_index` argument to `LinkState`. The purpose of this is to enable updating the state of single sessions on incoming BFD traps: BFD traps do not contain the actual state value changes, they only contain information about the set of BFD sessions that changed state to something up-like or something down-like. The changed state values need to be re-polled, but there is no need to poll the full table in these cases.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 3 files 3 suites 1m 15s ⏱️ Results for commit ec71030. ♻️ This comment has been updated with latest results. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/snmp-get2-multiple-variables #305 +/- ##
========================================================================
- Coverage 98.70% 98.69% -0.01%
========================================================================
Files 53 54 +1
Lines 7055 7100 +45
========================================================================
+ Hits 6963 7007 +44
- Misses 92 93 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I would like to have an updated news fragment - act is a strange choice here. IMO it makes more sense to simply remove Act to
from it.
As release manager I'm still responsible for editing the final changelog, so I'll just keep that in mind when the time comes :) Thank you! |
Scope and purpose
Fixes #292. Dependent on #303 to be merged first.
bfdSessUp
andbfdSessDown
traps only tell which BFD sessions have changed state and why, but does not actually include the new state value for the session. This means most of this new observer's work is to just offload everything toBFDTask
to poll the individual session(s) that have changed state and ensure state and events are updated accordingly.This pull request
BFDTask
to fetch and update single BFD sessions, used by the trap observer.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.