Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POLLINTF API command #300

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Jul 5, 2024

Scope and purpose

Fixes #218.

This pull request

  • changes the API

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
    • well, tests are documentation...
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (66c22f0) to head (4337546).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   97.79%   97.80%           
=======================================
  Files          55       55           
  Lines        7380     7395   +15     
=======================================
+ Hits         7217     7232   +15     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty to clean this up a little in your absence.

My changes made me realize that we should really consider adding a polldevs dict to the API server instance as well. The original reached into the global state, which isn't necessary, since the API server instance has a reference to the state. However, it still reaches out to the global polldevs dictionary, which I would prefer it didn't.

@lunkwill42 lunkwill42 merged commit d56ccec into Uninett:master Jul 9, 2024
9 checks passed
@lunkwill42 lunkwill42 mentioned this pull request Jul 9, 2024
6 tasks
@johannaengland johannaengland deleted the api/pollintf branch July 9, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the POLLINTF API command
2 participants